Jose' Matos wrote:
> I have implemented all the suggestions from the list, collapsed all
> the new file formats in one file.
The advantages of this approach have been discussed, and I see no
disadvantages, so I guess no comments are needed here.
> I placed also convert and revert in the same file, as as far as
> possible I placed both implementation near each other.
This is definitely an improvement, especially for symmetric changes such as
convert_spaces/revert_spaces.
> The new files will be:
> lyx_0_12.py
> lyx_1_0_0.py
> lyx_1_0_1.py
> lyx_1_1_4.py
> lyx_1_1_5.py
> lyx_1_1_6_3.py
> lyx_1_1_6.py
> lyx_1_2.py
> lyx_1_3.py
> lyx_1_4.py
I would like to see both ends of the conversion in the filename, e.g.
lyx_1_3_to_1_4.py. Otherwise, you can't see from outside which file converts
between two given versions: does lyx_1_3.py convert between 1.2 <-> 1.3 or
1.3 <-> 1.4? In fact this has nothing to do with the new naming scheme, I
don't like the existing one either, because it has the same problem ;-)
I have to admit that lyx_1_3_to_1_4.py is no good choice, because it implies
that only one direction is possible, but I have no better idea at the
moment.
> And those will replace all the existing lyxconvert* and lyxrevert*
>
> So, comments?
Instead of the lines
if format < 230:
format = 230
etc. I would rather print a warning that the conversion is not yet
implemented (only if a conversion is necessary of course).
This may annoy people enough so that they fix it.
In fact, I wrote the changes I sent because I got annoyed by "Missing
'sideways' parameter" messages.
Georg
