Alfredo Braunstein wrote:
> This is what I had to do for making it work (!).
>
> - restore BufferView::setCursor (I had emptied it out in the
> ParIterator patch for some reason, thinking it was not needed any
> more)
> - fix BufferView::putSelectionAt (this should be culled out at
> the end I think)
> - commented out LyXText::updateLocal. I presume that most of it is
> uneeded (mostly all that is view related). It should change name if
> it is so.
> - added InsetText::allowSpellCheck() const { return true; }
> - fix small bits of ControlSpellChecker. In particular, use
> cur.forwardPos instead of forwardChar (we need paragraph ends to
> identify word boundaries). Also added a check for inTexted. (btw, I
> suspect that lyx::find also suffers from some of these problems, but
> for some reason it seems inactive now)
Ouch!
Incidentally, I have a patch here that turns ControlSpellchecker into
a 'conventional' dialog controller. (Read: one whose logic I can
understand --- ie, simple!). It still does *far* too much though. I
think I see how to move most of the functionality into the core so
that the dialog simple receives data and dispatches
FuncRequest(LFUN_REPLACE_WORD, replacement)
Time will tell whether I'm right ;-)
> Patch attached (to be tested).
If it fixes the crash then please commit it.
Take out the getOutOf bit though.
--
Angus
