On Mon, Mar 29, 2004 at 02:14:53PM +0000, Angus Leeming wrote:
> Angus Leeming wrote:
>
> > LFUN_VIEW_REFRESH perhaps?
> >
> > lv_.view()->redoCurrentBuffer();
> > buffer()->markDirty();
> > lv_.message(_("Document settings applied"));
>
> Actually, I think I'd like to remove this code.
> 1. markDirty() is already invoked by the other LFUNs.
So drop it.
> 2. redoCurrentBuffer() is invoked ONLY from here. It is really needed?
*shrug* How should I know. This is old code. My approach so far was:
check whether it makes a difference, and if not, remove it.
Of course, after a document class change, all row cache info is sort of
unusable, but we do not rely on it too often anymore. Rebreaking is
certainly safe, but I wouldn't be surprised if it was not needed at all.
Andre'
