On Friday 27 February 2004 18:13, Georg Baum wrote:
> -        __import__(mode + str(fmt)).convert(header,body)
> +       if mode + str(fmt) == "lyxconvert_229":
> +            __import__(mode + str(fmt)).convert(header,body,opt.input)
> +       else:
> +            __import__(mode + str(fmt)).convert(header,body)

  This is ugly, really. ;-)

  As a mater of fact you could had simply tested fmt== 229 instead of that 
verbosity... :-)

  What I would like you to do, is to add the opt structure as an additional 
argument to all (back)converters.

  convert(header, body, opt)

  That transformation is then acceptable for me. I will do it with or 
without your patch because that will allow me to divert the errors for the 
appropriate place then using opt.err (as an example). There could be others 
uses, this is just an example.

  Using this scheme we have a simple and standard way of passing arguments 
to the converters.

  It is nice, clean and easier to maintain also.
  
-- 
José Abílio

LyX and docbook, a perfect match. :-)

Reply via email to