Andre Poenitz wrote:

>> The following patch should fix the crash. The culprit is that
>> insetcollapsable::edit(x,y) should not call insettext::edit(cur,x,y) when
>> opening (the inset was not visible before) but insettext::edit(cur,
>> true).
> 
> Hm.. is that a proper fix?

You tell me.

The fact is that it's kind of dumb to try to acess the insettext's
coordinates when it hasn't been drawn before: the user surely didn't
intended that when clicking (the inset wasn't visible). It seems cleaner to
me not to do it.

Otherwise, we should ascertain that we have coordinates before (i.e. an
update has been called) before calling LyXText::edit(x,y)... ugly.

Unrelated1: triple click fails because LyXText::dispatch takes a cur
argument but the 95% of it uses the real cursor. Smells fishy.

Unrelated2: MOUSE_PRESS opens a collapsable. MOUSE_RELEASE closes it. Guess
the outcome.

Alfredo



Reply via email to