Jean-Marc Lasgouttes wrote:

>>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
> 
> Angus> Attached are the changes in my 1.3.x tree.
> 
> Angus> * src/frontends/qt2 intelligent scrolling for Qt. This patch
> Angus> has been in the 1.4.x tree for weeks and no problems have
> been Angus> reported.
> 
> Yes. Actually I intended to ask for it before 1.3.4.

Ok.

> Angus> * src/text3.C LFUN_GETLAYOUT currently outputs "1" for all
> Angus> layouts rather than the more useful "Title", "Standard" etc.
> Angus> This one line patch causes it to output the useful data. An
> Angus> identical patch should go in the 1.4.x tree too.
> 
> Yes.

Ok.

> Angus> * src/frontends/xforms/xforms_helpers.C output some
> informative Angus> error messages if we fail to open
> preferences.xform for Angus> read/write. This patch should go in the
> 1.4.x tree too.
> 
> Yes. However you should consider whether you want to use _() around
> the strings (what is our policy) and use boost::format.

Good idea. I've plumped for
                lyxerr << "XformsColor::read(" << filename << ")\n"
                       << _("Failed to open file.") << std::endl;

> Angus> * src/insets/insetgraphics.C escape the name of the external
> Angus> file so that LaTeX can handle (f.ex) Cyrillic file names.
> This Angus> patch should go in the 1.4.x tree too.
> 
> Yes, provided you are sure it does what you think it does :)

I'll mull this one over/do some testing.

Angus


Reply via email to