Am Mittwoch, 10. Dezember 2003 19:34 schrieb Angus Leeming:
> The attached patch changes the lyx format to 227
>
> \begin_inset Boxed -> \begin_inset Box Boxed
> \begin_inset Doublebox -> \begin_inset Box Doublebox
> \begin_inset Frameless -> \begin_inset Box Frameless
> \begin_inset ovalbox -> \begin_inset Box ovalbox
> \begin_inset Ovalbox -> \begin_inset Box Ovalbox
> \begin_inset Shadowbox -> \begin_inset Box Shadowbox
>
> However, I'll hold off applying it because I'm unsure how best to
> proceed with lyx2lyx. The patch removes the just committed
> lyxconvert_225.py, lyxrevert_226.py, moving their contents into the
> new files lyxconvert_226.py, lyxrevert_227.py and augments these new
> files with convert_box functions. However, I can see that this is
> ugly.

Why do you remove these files? IMHO creating a new file format (here: 227) 
makes only sense if lyx2lyx can convert to and from the last format (here: 
226). If this is not possible you can as well include the box changes in 
the 226 format. The effect is the same: Files created in the original 226 
format cannot be read by later lyx versions.

> Would it be best to do this only once we freeze for a 1.4 release so
> that a released lyx2lyx would contain the equivalent of
> lyxconvert_13xformat.py and lyxrevert_14xformat.py?

This has the disadvantage that files created by some development snapshots 
cannot be converted anymore.

A side note: I find the filenames very confusing. I never know what 
lyxrevert_225.py or lyxconvert_225.py does: revert/convert _to_ 225 or 
_from_ 225?

> Also, I note that if I move lyxconvert_225.py to lyxconvert_226.py and
> then try and convert a 227 format file, I get an error that looks
> like a bug to me:


I get this one if I try to read a 225 file with lyx with your box patch:

$ ~/misc/lyx-devel/src/tex2lyx$ ../lyx minipage-new.lyx
Traceback (most recent call last):
  File "/home/georg/misc/lyx-devel/lib/lyx2lyx/lyx2lyx", line 197, in ?
    main(sys.argv)
  File "/home/georg/misc/lyx-devel/lib/lyx2lyx/lyx2lyx", line 190, in main
    __import__(mode + str(fmt)).convert(header,body)
ImportError: No module named lyxconvert_225


It works if I add an empty lyxconvert_225.py file and change the format list 
in lyx2lyx.


Georg




Georg


Reply via email to