Jean-Marc Lasgouttes wrote: > Angus> Jean-Marc, attached is the 'sane-scrolling' patch in > Angus> the 1.4.x. tree ported to the 1.3.x tree. IMO, It > Angus> works beautifully but, as ever, I leave it to you > Angus> to decide whether you want it in 1.3.4.
> I guess that if I ask you whether you are confident about the patch > you'll say "Yes!". So I won't bother to ask and tell you to go > ahead. I like the idea of having new features in 1.3.4. This will > allow me to work on a 1.3.5 which fixes problems :) Oh, you understand me so well! Am I confident the patch is safe? Well, yes: * It introduces one new member variable to QContentPane of type SyntheticMouseEvent. In turn this stores no pointer-like or dynamic data. Conclusion, it's unlikely to access invalid chunks of memory. * At the other end, it just throws away mouse events if you drag the cursor outside of the lyx screen, and re-issues a stored FuncRequest every <timer> interval. I'll leave it a few days to let the Qt-cvs users time to discover any vital flaws. -- Angus
