On Fri, Nov 21, 2003 at 06:02:31PM +0100, Michael Schmitt wrote: > Hello, > > this patch removes the bv parameter from the inset methods > open/close/status + removes a redundant update() call. > > Concerning the markDirty() calls, I noticed that there is a general > mechanisms which is based on the action type.
Ah yes. I should have remembered that... > I.e. we do not check whether a change has actually taken place. > Special cases like opening an open inset are not captured. Very well, > in this case we can simply remove the markDirty() calls :-) > > Please check and apply, > - inset->status(bv, s); > - return inset; > + return new InsetERT(params,s); Whitespace. Rest is ok. I'll commit that. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
