On Wednesday 22 October 2003 2:30 pm, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] writes: > | CVSROOT: /usr/local/lyx/cvsroot > | Module name: lyx-devel > | Repository: lyx-devel/src/insets/ > | Changes by: [EMAIL PROTECTED] 03/10/22 15:15:18 > | > | Modified files: > | lyx-devel/src/: ChangeLog buffer.C buffer.h factory.C > | lyx-devel/src/graphics/: ChangeLog PreviewLoader.C > | lyx-devel/src/insets/: ChangeLog insetcite.C insetcite.h > | > | Log message: > | Add a Buffer::fully_loaded member function, returning true only when > | the file has been loaded fully. Used to prevent the premature generation > | of previews and by the citation inset to prevent computation of > | the natbib-style label. > > Hmm... I am not sure... this should never be needed. > > When is a preview trieggered by loading of a doc? This could show some > ordering problems.
Exactly. I'm getting to the bottom of this slowly but surely. If I can then remove the Buffer::fully_loaded function, I will. However, the information is also needed by the citation inset. It had a really nasty hack as work around, which I've now been able to remove. > previews should be generated by _view_ not loading, and citation inst > should delay computation until view. I know. And I'm trying to do it. > A discussion would have been nice... Maybe. Sorry for that. However, I know what the problem is and how to prevent it (delaying the computation) but efficiency is also important. The current preview architecture doesn't make this easy. Basically, it's something of a mess and needs redesigning now that I understand how it all fits together. Meanwhile, the 'fix' is trivial and self documenting... Angus
