Lars Gullik Bjønnes wrote: > This patch does a sweep over all the code... there be bugs. > > But it basically work as intended, but I think I have been overeager > in a couple of cases. And in some cases I think more ref stuff > should be added so that some '*' can be removed. > > Have a look, have a go, have at it.
Why does showMessage::operator()(string m) in converters.C not take a "string const &" arg? I am extremely uncomfortable about the change in the frontend controllers: - Buffer const * Kernel::buffer() const; + Buffer const & Kernel::buffer() const; - Buffer const * ControlConnectBase::buffer() const; + Buffer const & ControlConnectBase::buffer() const; many of the dialogs that access these functions can be opened when no buffer is open at all. The Preferences dialog will just crash. Apart from that, it looks very good. -- Angus
