Martin Vermeer wrote:
> Perhaps I'd better have a closer look at LColor.[Ch]...
> Attached a first attempt for comment... as you see, I'm struggling.
Well, the header file looks pretty reasonable, although you should
aim to use
boost::scoped_ptr<Impl> pimpl_;
to store the implementation eventually.
(Incidentally, the idiom here is Pointer to Implementation. I have no
idea why we call the class Pimpl in LyX. To my mind Impl makes far
more sense...)
As for the .C file:
void fill(ColorEntry const & entry) {
...
- int & no = transform[entry.lyxname];
- no = entry.lcolor;
+ transform[entry.lyxname] = int(entry.lcolor);
}
The two LColor::getGUIName functions look pretty much how I imagined
them to be.
Where exactly are you struggling?
--
Angus
