On Tue, Jul 15, 2003 at 04:34:24PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Tue, Jul 15, 2003 at 03:01:23PM +0200, Andre' Poenitz wrote: > | > > | > This moves closer towards full redraw but there are regressions: > | > Selection in tables gets slow and when selecting bottom up, the > | > selection anchor "moves" in parallel to the cursor. > | > | I just noticed that this kind of cursor movement has already been > | present yesterday, so the current regression is performance only. > > So what you are saying is that this regression has been caused by one > of the earlier patches?
Yes, but not by one of today's patches. We could try binary search to find out... [OTOH, it's fairly leightweight.] ... Ok, I've just checked my latest Qt build, this has already the bug and was build on July 10 (17:00). > Depends... if we understand why the regressions is there or not... It looks as though the selection anchor is physically moved. Maybe it crept in during the rowlist changes and nobody noticed so far. I tried spotting a difference in the handling of LFUN_DOWNSEL (which works) and LFUN_UPSEL (which doesn't in tables), but didn't find any. [But I found another bug. LyXText::cursorUp(bool) is called with a BufferView * argument. [Which is fun, as it turns out that it doesn't matter whether it gets passed a true or a false ;-}] So given that this is an "old" bug, ok to proceed with the redraw/update changes? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
