On Wed, Jul 02, 2003 at 10:39:47PM +0200, Alfredo Braunstein wrote:
> This patch
>
> - introduces two new signals in buffer: busy and message. I've renamed
> parseError to error because it's used more generally than for parse errors.
> It could still use a better name maybe.
>
> - adds all three boost::signals::connection objects to BufferView::pimpl +
> connect/disconnect signals on buffer switching
>
> - use the new signals in buffer,converter,importer,exporter
>
> - adds a BufferView::newFile method to hide the BufferView::buffer call in
> that case.
>
> I've noticed that converter still needed BufferView: only for getLyXFunc,
> and that to pass this LyXFunc to LaTeX, who needs it for showing messages
> ("latex run nr."). So:
>
> - adds a 'message' signal to LaTeX
>
> - removes lyxfun/view dependency from converter/latex
>
> Comments very welcomed.
Code looks good.
I just wonder whether the whole signal business does not somehow undermine
the 'LFUN everywhere' approach. For peaceful coexistence I'd expect that
any 'unusual' signal gets delivered to LyXFunc::dispatch which in turn
figures out the BufferView, and calls dispatch() there - even if we already
know which BufferView is meant. This 'shorcut dispatch' somehow looks fishy
to me...
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
