Angus Leeming wrote:
> Alfredo Braunstein wrote:
>
>> +bool readFile(Buffer * b, string const & s)
>> +{
>> + string ts(s);
>> + string e = OnlyPath(s);
>> + string a = e;
>> + // File information about normal file
>> + FileInfo fileInfo2(s);
>> +
>
> Being pedantic, why do you call it fileInfo2 and not simply fileInfo?
Cut&Paste detritus... will change it.
> +/* \file buffer_funcs.h
> +/**
> + * Loads a LyX file \param filename into \param Buffer
> + * and \return success status.
> + */
> +bool loadLyXFile(Buffer *, string const & filename);
>
> Apparently these comments should be \c filename rather than \param...
Ok.
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/importer.C,v
> +#include "buffer_funcs.h"
>
> Do you need this? The diff suggests not.
Mmyes, for ::newFile
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v
> +#include "buffer_funcs.h"
>
> Ditto.
Same thing.
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/ChangeLog,v
> +2003-06-19 Alfredo Braunstein <[EMAIL PROTECTED]>
> +
> + * insetinclude.C (loadIfNeeded): call BufferView::loadLyXFile
> instead
> + of BufferList::loadLyXFile
> +
>
> It seems that you actually call ::loadLyXFile.
Ah yes... forgot to update that.
Thanks, Alfredo
