[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Are there any point in doing patches like this one? | | If so we should hunt for and kill over use of functions like this.
This is a list of for-loops that might be changed to not call end() in the test clause.
src/CutAndPaste.C:246: for (; tmpbuf != simple_cut_clone.end(); ++tmpbuf) { src/MenuBackend.C:327: for (const_iterator it1 = begin(); it1 != end(); ++it1) { src/changes.C:150: for (; it != table_.end();) { src/changes.C:263: for (; it != table_.end(); ++it) { src/paragraph_funcs.C:790: for (; cit != token.end(); ++cit) { src/frontends/qt2/QCharacter.C:107: for (; cit != vec.end(); ++cit) { src/frontends/qt2/QPrefsDialog.C:142: for (QStringList::Iterator it = families.begin(); it != families.end(); ++it) { src/frontends/qt2/QToc.C:165: for (; iter != toclist.end(); ++iter) { src/frontends/xforms/FormForks.C:310: for (vector<string>::iterator it = vec.begin(); it != vec.end(); ++it) { src/frontends/xforms/FormTexinfo.C:94: for (; it != vec.end(); ++it) { src/frontends/xforms/RadioButtonGroup.C:63: for (; it != map.end() && !isMember; ++it) { src/insets/insettext.C:2228: for (Cache::iterator it = cache.begin(); it != cache.end(); ++it) { src/mathed/formulabase.C:770: for (string::iterator it = str.begin(); it != str.end(); ++it) { src/mathed/math_autocorrect.C:121: for (const_iterator it = data_.begin(); it != data_.end(); ++it) src/mathed/math_cursor.C:361: for (string::const_iterator it = str.begin(); it != str.end(); ++it) src/mathed/math_data.C:37: for (iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:103: for (const_iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:111: for (const_iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:118: for (const_iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:134: for (const_iterator jt = ar.begin(); jt != ar.end(); ++jt, ++it) src/mathed/math_data.C:154: // for (const_iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:192: for (const_iterator it = begin(); it != end(); ++it) src/mathed/math_data.C:225: for (const_iterator it = begin(), et = end(); it != et; ++it) { src/mathed/math_data.C:258: for (const_iterator it = begin(), et = end(); it != et; ++it) { src/mathed/math_data.C:272: for (const_iterator it = begin(); it != end(); ++it) { src/mathed/math_data.C:288: for (const_iterator it = begin(), et = end(); it != et; ++it) { src/mathed/math_data.C:326: for (; currx < targetx && it < end(); ++it) { src/mathed/math_extern.C:319: for (MathArray::iterator it = ar.begin(); it != ar.end(); ++it) { src/mathed/math_extern.C:693: for (MathArray::const_iterator dt = denom.begin(); dt != denom.end();) { src/mathed/math_extern.C:809: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) { src/mathed/math_extern.C:818: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_extern.C:827: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_extern.C:836: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_extern.C:845: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_extern.C:854: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_extern.C:869: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_gridinset.C:191: for (string::const_iterator it = hh.begin(); it != hh.end(); ++it) { src/mathed/math_gridinset.C:219: for (string::const_iterator it = hh.begin(); it != hh.end(); ++it) src/mathed/math_hullinset.C:54: for (MathArray::const_iterator it = ar.begin(); it != ar.end(); ++it) src/mathed/math_macrotable.C:23: for (it = macro_table.begin(); it != macro_table.end(); ++it) src/mathed/math_support.C:382: for (string::const_iterator it = s.begin(); it != s.end(); ++it) { src/mathed/math_xyarrowinset.C:40: for (MathArray::const_iterator it = t.begin(); it != t.end(); ++it) { src/tex2lyx/text.C:100: for (string::const_iterator it = s.begin(), et = s.end(); it != et; ++it) {
-- Lgb