Jean-Marc Lasgouttes wrote: >>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> JMarc, could you have a look at this then. It appears to work > Angus> perfectly but... Angus > > Angus> (The !buf part of getStatus would eventually expand to cover > Angus> all relevant dialogs) > > It looks good, except that you should not return immediately when > you set flag.disabled() to false. In general you should only return > immediately if you are sure that there is no need to change the flag > anymore. So your last return statement should go. > > Actually, I see no reason why this code goes in such a special place > (at the beginning of the function) and not alongside other lfuns in > the big switch(ev.action).
Because the block immediately below it _returns_ to the calling function if the buffer is not present and NoBuffer is not set... -- Angus
