On Wed, Jun 11, 2003 at 08:22:23PM +0000, Angus Leeming wrote: > If you like this, then I guess that the next step is to remove InsetButton > and to use ButtonRenderer further. > > Comments/Suggestions?
Well, I don't like - string screenLabel() const; + virtual string const screenLabel() const; but I know Lars likes it. So maybe the point is already mood. Anyway: First of all, they are functionally equivalent, so it is a matter of style. (The only difference would be the ability to call a non-const member function on the returned object, but we don't do that anyway) My reasoning is twofold: 1. Any unneeded verbosity in the code hampers reading. I am only able to catch a limited amount of text on one glance, so if I have to dig for the 'real information' in a piece of code, this slows me down. I don't like that. 2. Putting the virtual only to the 'base function' allows easy greps for base function. I do that sometimes and I like that. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
