Alfredo Braunstein wrote:
> John Levon wrote:
>
>> Please do, it looks like we can regain a few percent from this
>
> Does this betters out things... and uh... is correct? (Angus please check)
>
> Regards, Alfredo
Looks good except for this:
> Index: frontends/Dialogs.C
> Dialog * Dialogs::find(string const & name)
> {
> - if (!isValidName(name))
> - return 0;
> -
> std::map<string, DialogPtr>::iterator it =
> dialogs_.find(name);
>
> if (it == dialogs_.end()) {
> + if (!isValidName(name))
> + return 0;
> dialogs_[name] = DialogPtr(build(name));
> return dialogs_[name].get();
> }
If the name isn't valid it's because the dialog isn't implemented in that
frontend. It should be the first test therefore.
ps, as of tomorrow am I'm away till Monday.
--
Angus
