Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
|
| Ok, looking it over. It basically seems to be a straight transformation as
| the iterator and pointer are almost always simply dereferenced. I haven't
| come across any next() or ++() operations yet.
|
| However, this seems to be a regression:
| - Paragraph const * newpar = row.par();
| + ParagraphList::iterator newpit = row.par();
|
| If const_iterator does not yet exist, then why not flag this change as
| + ParagraphList::iterator const newpit = row.par();
|
|
| Ok, the very next block is suspicious. What happens if newpit == begin()
| _before_ you --() it?
| - newpar = newpar->previous();
| - } while (newpar
| - && newpar->getDepth() >= row.par()->getDepth());
| + --newpit;
| + } while (newpit != ownerParagraphs().begin()
| + && newpit->getDepth() >= row.par()->getDepth());
Bad stuff.
The d0 {} while(...), needs to be rewritten to while(...) {}
--
Lgb
