>>>>> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes:

Dekel> On Fri, Mar 07, 2003 at 06:33:08PM +0100, Jean-Marc Lasgouttes
Dekel> wrote: I want to port the following patch to 1.3.1cvs (the
Dekel> patch is against HEAD). It add 'hspell' option to the list of
Dekel> spell-checkers (hspell is a spell-checker for Hebrew). Is it OK
Dekel> ?
>>  Well, I want to see the final patch first. Does xforms need a
>> similar patch?

Dekel> I've attached a patch against 1.3.1cvs Xforms needs such a
Dekel> patch, but since the xforms spellcheking dialog cannot show
Dekel> Hebrew properly, it doesn't make much sense to make such a
Dekel> patch.

Is there a good reason why it cannot show hebrew? 

>> [Sorry for the nice paragraph rebreak]
>> 
>> Is it really necessary to use such a loop? Isn;t there some kind of
>> setCurrentItem(QString)?

Dekel> There is, but only in QT3 (according to the docs).

>> More generally, I am not a very big fan of last-minute fixes. This
>> is not even in 1.4.0.cvs... Can this wait until 1.3.2? We have
>> other patches in the queue already.

Dekel> I guess it can wait, but the patch is quite small.
 
I'll apply it now.

JMarc

Reply via email to