Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > | (Have you looked at the patch?) | > No. Haven't looked, but your solutions seem very sound. | | Off topic I know, but haven't you ben asking people to send patches to the | list for review? Not quite "formal" review, but more "peace of mind" | review. Without meaning to be rude, I would have thought that such a | request placed _some_ onus on you to at least look at the proposed patches.
For this specific patch the solution sounded simple, so it was actually my confidence in you that made me _not_ look at the patch. | Not that I'm upset that you don't say "Well done, Angus, this is super and I | recommend you commit it asap" more often ;-) I look at a lot of more patches than I comment on. But you havent done things in the code that I mostly linger in lately... so then I do not have a lot to comment on. (There are limits even to my nit-picking...) -- Lgb