Alfredo Braunstein wrote:
> So here it is. Please comment.
Loks good. Here's some comments ;-)
Angus
* Copyright 2002 the LyX Team
There is no such formal entity. Please use
/**
* \file format.C
* This file is part of LyX, the document processor.
* Licence details can be found in the file COPYING.
*
* \author Dekel Tsur
*
* Full author contact details are available in file CREDITS
*/
// FIXME: horrednously mis-named, especially given the other ::add
// function
void Formats::add(string const & name, string const & extension,
string const & prettyname, string const & shortcut)
So fix it ;-)
//does this belong here??
string const Formats::papersize(Buffer const * buffer) const
It doesn't 'feel' right does it. Why not make it a stand-alone function?
#ifndef FORMAT_H
#include <string>
#include <vector>
using std::string;
using std::vector;
using std::endl;
Use "LString.h" rather than <string>. Do NOT pollute header files with using
std::xyz. Why do you need endl anyway?
inline
bool operator<(Format const & a, Format const & b)
Why is it inline? Have you profiled this code? Take it out of line.
