On Tuesday 25 February 2003 1:39 pm, John Levon wrote:
> On Fri, Feb 21, 2003 at 04:56:55PM +0000, Angus Leeming wrote:
> > until that is done. However, the attached patch is the Brave New World of
> > controllers and I'd value your considered perusal.
>
> Hrm, it's not very Linus friendly is it :
>
> 95 files changed, 2471 insertions(+), 881 deletions(-)
>
> Oh hrm, I guess this is because of the intermediate state ...
That's right. When everything has been ported over
ControlButtons.[Ch] ControlConnections.[Ch] ControlDialog.h
ControlDialog_impl.[Ch] ControlDialog.tmpl ControlInset.h ControlInset.tmpl
GUI.h ViewBase.h
will all just dissappear. So that's another 1094 deleted lines. In fact, I
believe that the functionality of all the above can already be found in
Dialog.[Ch] (366 lines).
> Why all the near-duplicated code in BufferView_pimpl.C ? Can't you
> templatise this :
>
> + case LFUN_CITATION_APPLY: {
> to at least some degree ?
I would love to. But several of them have subtle differences. I think that we
should first establish how to do this generically. Probably needs another
inset method that can be specialized for the different insets.
> > with full control over the contents. The hook exists
> > (LFUN_DIALOG_SHOW_NEXT_INSET "name") to open the dialog of the next inset
> > after the cursor of a given type (or even just the next inset with a
> > dialog...) but there is no code to do so and I don't propose adding it.
> > feel free to take up that particular baton.
>
> OK. What about getStatus() of these ? Is that almost ready to fly too ?
Me need more explain. Please ?
> It looks good, I think, but it's hard to see in patch form, especially as
> the old code still exists ;)
Shall I just commit it and let people try it out. What's the consensus on
this?
Angus
