[EMAIL PROTECTED] wrote: > > Hello, Angus, > > Attached is another xforms-i18n patch in which > > 1. I made XFontSet to be loaded only on the machine with locales set > Chinese, Japanese or Korean ( or their aliases, of course).
Ugly!!! Still I guess that you have to release sometime. Fair enough. > 2. The messy part in handle_key in input.c is removed so that the order is > back to the original. Good. One more thing that need not delay the release. Why do you have three + if(use_fontset()) + activate_CJK_composition(ob); in input.c? Ditto, this should not prevent you kicking the relase out the door, but is really nasty: +#define use_fontset use_fontset() Also your indentation sucks ;-) +if (use_fontset) + XmbdrawString = (mbDrawString) (img ? XmbDrawImageString : XmbDrawString); +else + XdrawString = (DrawString) (img ? XDrawImageString : XDrawString); > Please quick-look at the patch, and if it looks fine, give me a sign. I'm > ready to announce CJK-LyX-1.3.0. Announce it and await the bug reports. Good luck ;-) -- Angus
