Re: [Bug 814] Visualize vertical spaces (small/med/bigskip)

[Michael Schmitt]

Dear Jean Marc,

Is there a reason why no arrow is shown in the case of small/med/big/skip?

Not really...

I'll apply nevertheless, but will not close right now

The attached patch fixes the problem. Please apply it to 1.3.1cvs and
1.4.0cvs.

Thanks, Michael


Index: lyx-devel-1.3.Xcvs/src/text.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/text.C,v
retrieving revision 1.283.2.1
diff -u -r1.283.2.1 text.C
--- lyx-devel-1.3.Xcvs/src/text.C       2003/02/07 15:10:57     1.283.2.1
+++ lyx-devel-1.3.Xcvs/src/text.C       2003/02/07 23:48:55
@@ -3273,20 +3273,17 @@
 
        str = prefix + " (" + vsp.asLyXCommand() + ")";
 
-       switch (vsp.kind()) {
-       case VSpace::LENGTH: {
+       if (vsp.kind() == VSpace::VFILL ) {
+               ty1 = ty2 = start;
+               by1 = by2 = end;
+       } else {
                // adding or removing space
-               bool const added = !(vsp.length().len().value() < 0.0);
+               bool const added = vsp.kind() != VSpace::LENGTH ||
+                                  vsp.length().len().value() > 0.0;
                ty1 = added ? (start + arrow_size) : start;
                ty2 = added ? start : (start + arrow_size);
                by1 = added ? (end - arrow_size) : end;
                by2 = added ? end : (end - arrow_size);
-               break;
-       }
-       default:
-               ty1 = ty2 = start;
-               by1 = by2 = end;
-               break;
        }
 
        int const leftx = p.xo + leftMargin(p.bv, p.row);
@@ -3305,9 +3302,6 @@
        p.pain->rectText(leftx + 2 * arrow_size + 5,
                         start + ((end - start) / 2) + d,
                         str, font);
-
-       if (vsp.kind() != VSpace::LENGTH && vsp.kind() != VSpace::VFILL )
-               return size;
 
        // top arrow
        p.pain->line(leftx, ty1, midx, ty2, LColor::added_space);