Michael Schmitt wrote:

> Dear Angus,
> 
> did my last change fix the setCookie problem on my web page?
> 
> In the meantime, I had an idea why there are PHP warnings at the end
> of the document. As you can see, I have activated PHP error
> reporting at the beginning of the script. This is quite useful
> because people tend to make mistakes such as using uninitialized
> variables. Since PHP swallows many problems silently by default, I
> think the report on my web page indicates an error in the LyX web
> framework that has not been detected before.
> 
> In other words: end.php3 should check whether "counter_file" and
> "translator" are set (with function isset(...)) before using them.
> 
> Michael

Bingo! Find your page at
http://www.devel.lyx.org/~leeming/www-devel/i18n.php3
(note the '3' on the end, consistent with the other files.)

Your page is all very well, but people should be able to 
find it ;-) Are you planning on adding something to translation.php3 
or similar?

Lars, I've made the change below to end.php3. May I commit this and 
Michael's new page?

Angus

Index: end.php3
===================================================================
RCS file: /usr/local/lyx/cvsroot/www-devel/end.php3,v
retrieving revision 1.11
diff -u -r1.11 end.php3
--- end.php3    28 Nov 2002 01:41:22 -0000      1.11
+++ end.php3    23 Jan 2003 14:12:16 -0000
@@ -38,7 +38,7 @@

 <?php
 // only the main home page defines this file, so we only count hits 
to that page
-if ($counter_file) {
+if (isset($counter_file)) {
        counter($counter_file);
 }
 ?>
@@ -46,7 +46,7 @@
 <address>
 <?php
 echo "Webmaster: <a 
href=\"mailto:[EMAIL PROTECTED]\";>[EMAIL PROTECTED]</a>\n";
-if ($translator) {
+if (isset($translator)) {
        echo "Translator:<a 
href=\"mailto:$translator\";>$translator</a>";
 }
 echo "\n";

-- 
Angus

Reply via email to