>>>>> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:

Michael> First, the top menu is called "View". Second, within menu
Michael> "View" only viewable formats are listed. So I don't
Michael> understand why "ASCII" should be listed in submenu
Michael> "View>Update". Makes no sense to me. I don't even know how to
Michael> view it (where is the file located).

OK, forget about it. You are of course right (I tended to mixup the
use of Update and Export).

Michael> Hmmm, while thinking about it: This patch could be committed
Michael> right now independently from the rest (just like the
Michael> misleading alert in buffer.C)...

Probably.

>> + for (; it != end; ++it) { + if (it == beg && +
>> !buffer->params.getLyXTextClass().isTeXClassAvailable()) +
>> continue; + if (converters.isReachable(*it, format)) return true;
>> 
>> I do not like this one. What does "it == beg" mean? Also, it would
>> be much better to move this test in converters.isReachable somehow.
>> I have to admit that I do not know how.
>> 
Michael> The first element is "latex", "docbook", or similar. I agree
Michael> that the code is not optimal. Suggestions?

Instead of "it == beg" one could test whether the converter has the
Converter::latex flag on. But I guess you want to cater for linuxdoc
and docbook too...

>> case LFUN_EXPORT: - disable = ev.argument == "fax" && -
>> !Exporter::IsExportable(buf, ev.argument); + disable =
>> !Exporter::IsExportable(buf, ev.argument); break;
>> 
>> Why is this necessary?
>> 
Michael> I want to disable the menu entries for unreachable exports.

You mean that you want them in the list, but disabled, right? Why not.
But why will they be in the export list although
Exporter::IsExportable is false? This is a very weird API.

JMarc

Reply via email to