Re: Index dialog in qt frontend

[Juergen Spitzmueller]

John Levon wrote:
> Why doesn't xforms have the same problem

because it calls bc().valid() directly from within update().
The attached patch cures the index and url problems.
Any other cases I missed? Is it intentional that an empty label can be 
inserted?

Jürgen
Index: src/frontends/qt2/ChangeLog
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/ChangeLog,v
retrieving revision 1.380
diff -u -r1.380 ChangeLog
--- src/frontends/qt2/ChangeLog	2003/01/14 21:51:33	1.380
+++ src/frontends/qt2/ChangeLog	2003/01/15 17:49:25
@@ -1,3 +1,8 @@
+2003-01-15  Juergen Spitzmueller  <[EMAIL PROTECTED]>
+
+	* QIndex.C:
+	* QUrl.C: fix validation on update().
+
 2003-01-11  Juergen Spitzmueller  <[EMAIL PROTECTED]>

 	* FileDialog.C: implement opendir [bug 824], fix mask.
Index: src/frontends/qt2/QIndex.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/QIndex.C,v
retrieving revision 1.16
diff -u -r1.16 QIndex.C
--- src/frontends/qt2/QIndex.C	2002/12/17 20:37:10	1.16
+++ src/frontends/qt2/QIndex.C	2003/01/15 17:49:27
@@ -44,7 +44,10 @@

 void QIndex::update_contents()
 {
-	dialog_->keywordED->setText(toqstr(controller().params().getContents()));
+	string const contents = controller().params().getContents();
+	dialog_->keywordED->setText(toqstr(contents));
+
+	bc().valid(!contents.empty());
 }


Index: src/frontends/qt2/QURL.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/QURL.C,v
retrieving revision 1.12
diff -u -r1.12 QURL.C
--- src/frontends/qt2/QURL.C	2003/01/04 21:42:59	1.12
+++ src/frontends/qt2/QURL.C	2003/01/15 17:49:27
@@ -54,6 +54,8 @@
 	dialog_->urlED->setText(toqstr(params.getContents()));
 	dialog_->nameED->setText(toqstr(params.getOptions()));
 	dialog_->hyperlinkCB->setChecked(params.getCmdName() != "url");
+	
+	bc().valid(isValid());
 }