On Sunday 12 January 2003 8:40 pm, Michael Schmitt wrote: > Hi, > > attached please find a patch for bug #819 (spurious spacing after > previewed formula). > > After a long search, it turned out that the width of xforms images is > not computed correctly; actually, a former "fix" makes things go wrong. > I guess the fix was for an old xforms version. But even if the fix > worked for xforms, it introduced an inconsistency with QT because the > code for the graphics inset relied on the incorrectness of the patch :-( > So after all, I think that rendering with QT should also become better > with my patch. > > GUI experts, please check the patch and - if correct - commit it. > > Thanks, Michael
Index: src/frontends/xforms/xformsImage.C Good! In fact: fantastic! Index: src/insets/insetgraphics.C This looks like the right thing to do although it also looks like a right pain in the arse. I take it that TEXT_TO_INSET_OFFSET is the width of the frame that separates the content of the inset (image) from the rest of the lyx page. I take it that mathed doesn't have such nastiness because André has written a frame-inset that does just this? Index: src/mathed/formula.C This doesn't look right. Who's meant to draw that extra pixel if you've moved it from Formula::draw? Also, can you explain why we need this? I'll read your answers at home this evening unless you cc [EMAIL PROTECTED] Jolly well done anyway! -- Angus
