A question about a comment...

[Angus Leeming]

Lars, could you give me a brief précis of what you're talking about here and 
what the xforms bug is/was. Does it still exist with xforms 1.0?

Do we ever get to that 
        } else
                break;
point?

Angus

        // Note that we need this handling because of a bug
        // in XForms 0.89, if this bug is resolved in the way I hope
        // we can just use the keysym directly without looking
        // at key at all. (Lgb)
        KeySym ret_key = 0;
        if (!key) {
                // We might have to add more keysyms here also,
                // we will do that as the issues arise. (Lgb)
                if (keysym == XK_space) {
                        ret_key = keysym;
                        lyxerr[Debug::KEY] << "Using keysym [A]" << endl;
                } else
                        break;
        } else {
                // It seems that this was a bit optimistic...
                // With this hacking things seems to be better (Lgb)
                //if (!iscntrl(key)) {
                //      ret_key = key;
                //      lyxerr[Debug::KEY]
                //              << "Using key [B]\n"
                //              << "Uchar["
                //              << static_cast<unsigned char>(key)
                //              << endl;
                //} else {
                ret_key = (keysym ? keysym : key);
                lyxerr[Debug::KEY] << "Using keysym [B]" << endl;
                //}
        }