On Wednesday 04 December 2002 9:05 pm, Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> | It looks big, but it's actually trivial with no change in functionality.
> | See ChangeLog.
>
> But you do change behaviour.
>
> | -void waitForX()
> | +void waitForX(bool discard)
> | {
> | - XSync(fl_get_display(), 0);
> | -}
>
> rationale?
XSync is called in two places as:
waitForX();
XSync(fl_get_display(), true);
It made sense to wrap both as
waitForX(false);
waitForX(true);
respectively, where we pass bool discard.
> | + if (!ev || !area->scrollbar)
> | + break;
> | +
[snip]
> | - // Check if the mouse is above or below the workarea
> | - if (drag_y >= area_y + area_h || drag_y <= area_y) {
> | - // we are outside, then we must not give too many
> | - // motion events.
> | - if (timdel.running())
> | + // Check if the mouse is outside the workarea
> | + if (drag_x <= area_w || drag_x >= area_x + area_w ||
> | + drag_y <= area_y || drag_y >= area_y + area_h) {
>
> Why this change? Now line selection when having the mouse ourside the
> workarea on the left or right side will be sluggish.
It made sense at the time, but I'll revert it. Note also that your original
was unsafe as you didn't check if ev existed.
> | - XSync(fl_get_display(), 1);
> | - // This purge make f.ex. scrolling stop immidiatly when
> | + waitForX(true);
> | + // This purge make f.ex. scrolling stop
> | immediately when
>
> ok then...
Thanks.
Angus
