On Tue, Nov 26, 2002 at 07:02:21PM +0100, Lars Gullik Bj?nnes wrote: > +string makeFontName(string const & family, string const & foundry) > +{ > + if (foundry.empty()) > + return family; > +#if QT_VERSION >= 300 > + return family + '[' + foundry + ']'; > +#else > + return foundry + '-' + family; > +#endif > +} > > is it ok to not have ' ' after family in qt3 case?
I forgot to add the space. I guess that qt3 accept that, but I will change to the documented format. > the else is not needed, too few spaces and then you are identical to > the function above... So should I move this function to frontends/qt/qt_helpers.C (this file doesn't exist now) ?