Angus Leeming wrote:
> Thanks Jürgen for the feedback. I've modified CheckChoiceClass to this:
Good. The difference between the old and the new (and qt) method is, AFAICS,
that the warning now comes after applying while it came on class change in
the dialog before. I don't know what is better though.
> Why doesn't Qt check if the textclasslist is loadable? In fact, why don't
> we have a wrapper for textclasslist[new_tc].load() in the controller that
> posts up the warning if unsuccessful?
Because we have not been clever enough?
> bool ControlDocument::loadTextclass(unsigned int tc) {
> bool const success = textclasslist[tc].load();
> if (!success)
> // problem changing class
> // -- warn user (to retain old style)
> Alert::alert(_("Conversion Errors!"),
> _("Errors loading new document class."),
> _("Reverting to original document class."));
> }
> return success;
> }
>
> Then this stuff can come out of ControlDocument::classApply which,
> therefore, no longer needs to return a bool.
Looks sensible.
> Shall I do this?
IMHO yes. Please.
Thanks,
Jürgen.
> Angus
