On Wed, Nov 06, 2002 at 04:06:15PM +0000, Angus Leeming wrote:
> The whole point of this exercise was to clean-up the code in biblio.C. As a 
> side effect, boost::regex searching now works in the same way as 1.2.

95 lines added, 71 removed... I'd like the other way round better...

Is it necessary to have the simple/regex distinction at all?
regex alone should be sufficient, shouldn't it?

[Even if we want a  "simple" item in the UI, the search pattern could be
mapped to a regexp.]


>       vector<string>::const_reverse_iterator rit(start);
+       vector<string>::const_reverse_iterator rend = keys.rend();
+       rit = std::find_if(rit, keys.rend(), match);

Why not

       rit = std::find_if(rit, rend, match);

if you already bothered to define it?

Andre'

-- 
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)

Reply via email to