On Friday 25 October 2002 12:41 pm, Rob Lahaye wrote:
> Angus Leeming wrote:
> > Here are the remaining four dialogs from Rob's monster
> > patch. Printer, Spellchecker, Texinfo and Wrap.
> >
> > All the diff's look fine to me, they all compile and I've
> > tried them out in minimal fashion. Ok to apply?
>
> Two questions/remarks:
>
> 1) FormWrap.h has NO longer the line:
>
> virtual ButtonPolicy::SMInput input(FL_OBJECT *, long);
>
> but FormWrap.C still has:
>
> ButtonPolicy::SMInput FormWrap::input(FL_OBJECT *, long)
> {
> return ButtonPolicy::SMI_VALID;
> }
Not here it doesn't and my version is identical to that in cvs.
mv FormWrap.C FormWrap.C_safe
cvs update FormWrap.C
> This function has become redundant, I suppose.
Yes, it was identical to that in FormBase.C.
> 2) External.h has the line:
>
> ButtonPolicy::SMInput input(FL_OBJECT *, long);
>
> There's no "virtual" here. Is that on purpose or is it
> missing by mistake?
sloppiness perhaps. It derives from FormBase which defines this
function as virtual. See André's note.
Angus
