On Thursday 24 October 2002 12:56 pm, Rob Lahaye wrote:
> John once refused to apply a patch of mine because the
> tooltips were not proper English, i.e. ending with a full
> stop! So I did my best to write tooltips in proper
> English.....and now you are removing the full stops at the end
> !?!?! Grumph, grumph....
My bad. I suddenly decided that tooltips didn't end with full stops.
Did no research of course. I've now had a look and discovered that
every other tip does use 'em, so I'll fix these.
> + igp.scale =
> strToDbl(getString(file_->input_width)); + if
> (igp.scale == 0.0) {
> + igp.scale = 100.0;
> }
>
> At this spot the scale is flipped to 100.0 if its (too close
> to) zero. (Should we use "if (!lyx::float_equal(scale, 0.0,
> 0.05))" instead, or not?).
Yes. Thanks for pointing it out. I'll fix it.
Angus
> Now I think of it, we may better use "scale = -1" (or any
> negative value) to indicate the use of width/height. Checking
> "scale < 0" is safer than checking "scale == 0.0", isn't it?
Nah. What we have is fine. If implemented correctly.
A
