Rob Lahaye wrote:
> Rob Lahaye wrote:
> 
>>Angus,
>>
>>The Alignment radiobuttongroup of 4 buttons in the Paragraph dialog (with
>>my patch applied!) behaves differently from the Placement buttongroup of
>>3 buttons in the Float dialog. And I can't find the reason for this
>>different behaviour.
> 
> 
> Argh, got it!
> The buttons in Float are PUSH_BUTTONS, the other ones RADIO_BUTTONS.
> They look the same in fdesign, so easy to miss!
> 
> Hold your breath, I'm coming with a patch really soon!!

Patch attached. This fixes a bug, so please apply!
The ChangeLog says:
 * FormFloat.C (input): fix the radio buttongroup behaviour.

 * RadioButtonGroup.C (init): Assert on ROUND3DBUTTON and RADIO_BUTTON when
   adding object to the group.

 * forms/form_float.fd: use RADIO_BUTTON for the buttons in the radio group.


In RadioButtonGroup.C, I decided to assert on "ROUND3DBUTTON" (all
radio buttons must have the same appearance) and "RADIO_BUTTON"
(an absolute requirement to have the radio-stuff work!).

With this (new) knowledge on the radio buttons, I have fixed, improved
and simplified the input() of FormFloat.C.

Rob.

Attachment: RadioButtonFix.diff.gz
Description: application/gzip

Reply via email to