Allan Rae wrote: > > How broken will things get if we put Rob's patch in before 1.3.0? > Maybe my memory is fuzzy but isn't it only cleanup and working on > MVCing Document?
No, it's not that. But many other goodies Xforms/GUI related. See below. > If it's going to break Qt in a big way then it shouldn't go in but if > it's only little or no work to fix Qt maybe it could be worth putting > it in. No extra work needed for Qt; Qt just compiles as is. I'm using the patched version for work right now and it's running fine. I haven't reworked all dialogs yet, but the ones I have, are so much better, especially Find&Replace, Spellchecker, Float, Paragraph, Latex information. Be aware that this is a huge patch though: New files: src/frontends/xforms/checkedwidgets.C src/frontends/xforms/checkedwidgets.h Redundant files: src/frontends/Liason.C src/frontends/Liason.h Patched files: src/PrinterParams.h | 2 src/frontends/Makefile.am | 2 src/frontends/controllers/ButtonController.tmpl | 13 src/frontends/controllers/ButtonControllerBase.C | 28 src/frontends/controllers/ButtonControllerBase.h | 27 src/frontends/controllers/ControlDialog.tmpl | 6 src/frontends/controllers/ControlInset.tmpl | 6 src/frontends/controllers/ControlParagraph.C | 14 src/frontends/controllers/ControlParagraph.h | 6 src/frontends/controllers/ControlPrint.C | 162 ++++- src/frontends/controllers/ControlSearch.C | 5 src/frontends/controllers/ControlSpellchecker.h | 6 src/frontends/xforms/FeedbackController.C | 6 src/frontends/xforms/FormAboutlyx.C | 57 + src/frontends/xforms/FormAboutlyx.h | 4 src/frontends/xforms/FormBibtex.C | 118 ++- src/frontends/xforms/FormCitation.C | 54 - src/frontends/xforms/FormDocument.C | 680 ++++++++++------------- src/frontends/xforms/FormDocument.h | 2 src/frontends/xforms/FormFloat.C | 240 ++++---- src/frontends/xforms/FormFloat.h | 4 src/frontends/xforms/FormGraphics.C | 211 +++---- src/frontends/xforms/FormGraphics.h | 1 src/frontends/xforms/FormLog.C | 21 src/frontends/xforms/FormMathsPanel.C | 2 src/frontends/xforms/FormParagraph.C | 489 ++++++++-------- src/frontends/xforms/FormParagraph.h | 4 src/frontends/xforms/FormPreamble.C | 14 src/frontends/xforms/FormPrint.C | 158 ++--- src/frontends/xforms/FormPrint.h | 5 src/frontends/xforms/FormSearch.C | 43 + src/frontends/xforms/FormShowFile.C | 7 src/frontends/xforms/FormSpellchecker.C | 195 +++--- src/frontends/xforms/FormSpellchecker.h | 8 src/frontends/xforms/FormTabular.C | 60 +- src/frontends/xforms/FormTexinfo.C | 96 ++- src/frontends/xforms/FormWrap.C | 99 +-- src/frontends/xforms/FormWrap.h | 4 src/frontends/xforms/Makefile.am | 2 src/frontends/xforms/RadioButtonGroup.C | 38 - src/frontends/xforms/RadioButtonGroup.h | 23 src/frontends/xforms/xforms_helpers.C | 23 src/frontends/xforms/xforms_helpers.h | 11 src/frontends/xforms/forms/form_aboutlyx.fd | 149 +---- src/frontends/xforms/forms/form_bibtex.fd | 139 ++-- src/frontends/xforms/forms/form_browser.fd | 21 src/frontends/xforms/forms/form_citation.fd | 30 - src/frontends/xforms/forms/form_document.fd | 458 +++++++-------- src/frontends/xforms/forms/form_float.fd | 190 ++++-- src/frontends/xforms/forms/form_graphics.fd | 71 -- src/frontends/xforms/forms/form_maths_panel.fd | 67 +- src/frontends/xforms/forms/form_paragraph.fd | 485 ++++++---------- src/frontends/xforms/forms/form_preamble.fd | 26 src/frontends/xforms/forms/form_print.fd | 16 src/frontends/xforms/forms/form_ref.fd | 32 - src/frontends/xforms/forms/form_search.fd | 117 +-- src/frontends/xforms/forms/form_spellchecker.fd | 79 +- src/frontends/xforms/forms/form_texinfo.fd | 35 - src/frontends/xforms/forms/form_wrap.fd | 113 +-- src/insets/insetgraphics.C | 2 src/insets/insetgraphicsParams.C | 13 src/insets/insetgraphicsParams.h | 2 62 files changed, 2598 insertions(+), 2403 deletions(-) Noone would be more delighted than me if this will merge with 1.3.0 :). Regards, Rob.
