On Sat, Oct 19, 2002 at 10:49:22PM +0200, Lars Gullik Bjønnes wrote:
> I have been having some fun...
+ // bool succes = // usused
YUCK !
// FIXME: do we need to use return value from classApply() here
// ??
classApply();
please !
-void QCommandBuffer::complete_selected(const QString & str)
+void QCommandBuffer::complete_selected(QString const & str)
You've tested this part is safe ?
- void complete_selected(const QString & str);
+ void complete_selected(QString const & str);
and this.
- qWarning("%d", s);
+ //qWarning("%d", s);
If you're going to get rid of the debugging comments while it's still
being worked on just remove them :)
- QLyXKeySym const & o = static_cast<QLyXKeySym const &>(k);
- // ignore text_ !
- return o.key_ == key_;
+ return static_cast<QLyXKeySym const &>(k1).key()
+ == static_cast<QLyXKeySym const &>(k2).key();
+
Please don't remove this comment - it is unusual behaviour.
- void symbol_clicked(string str);
+ void symbol_clicked(string const & str);
You forgot to fix the connect.
- // Yes, it is this ugly. Two reasons - root items must have a QListView parent,
- // rather than QListViewItem; and the TOC can move in and out an arbitrary
number
- // of levels
+ // Yes, it is this ugly. Two reasons - root items must have
+ // a QListView parent,
+ // rather than QListViewItem; and the TOC can move in and
+ // out an arbitrary number of levels
Why did you fubar the formatting ?
+Stuff to be aware of
Note that connections not from Qt code can still use our way, they just have to match
at
source, destination, and connect()
+ // FIX! (Lgb)
+
Please explain.
- bitBlt(p,
- 0, dest_y, // dest x,y
- p, 0, src_y, // source x, y
- src_w, src_h // source w, h
- );
+ // bitBlt(dest, dest_x, dest_y, source, src_x, src_y, src_w, src_h)
+ bitBlt(p, 0, dest_y, p, 0, src_y, src_w, src_h);
???
Most boring I've ever read :)
regards
john
>
> I have looked through all the qt files and fixed small stuff, a lot of
> ws changes, nothing special...
>
> As part of this I also wanderd briefly into the xforms and controllers
> directories.
>
> Please have a look at this patch... look fast it is pretty large...
>
>
--
"It's a cardboard universe ... and if you lean too hard against it, you fall
through."
- Philip K. Dick
