Angus Leeming wrote:
Check out the use of the checkedGlueLengths here!
Ooooooohhhh! You're left in no doubt that you've entered
something dumn. Rob, I've made it a little less in-your-face by
setting only LCOL1 to red. That way, the user won't get irritated too
much as he tries to enter the value, but if he clicks elsewhere, then the
feedback is really, really obvious ;-)
This patch is big, but is mainly cosmetic. At least, I haven't
found anything that's wrong. Of course, it's hard to be sure...
Rob, can I ask how thoroughly you've tested this and whether
you think it's in a fit state to apply?
All changes are merely rearranged logic things, which I have tested
thoroughly. Also, I'm using LyX with my patch in it already for some
time and things go well.
I'd say: give it a go :).
One small thing to remove:
@@ -386,6 +414,9 @@ void FormDocument::update()
language_update(params);
options_update(params);
bullets_update(params);
+
+ // reset widgets to valid input
+ input(NULL, 0);
}
The "input(NULL, 0);" is obsolete; remove it completely! All three "+" can go.
The reason: input() does nothing at all when ob = NULL!
