Lars Gullik Bjønnes wrote:
> Rob Lahaye <[EMAIL PROTECTED]> writes:
> 
> | +if test -z $GNUM4 ; then
> 
> This test looks wrong... what happens if GNUM4 is not set?

Hey, look at the scipt. The script does now:

# Autogenerate lib/configure.m4.
if test x$GNUM4 != x ; then
     echo -n "Building lib/configure ... "
     rm -f lib/configure
     $GNUM4 lib/configure.m4 > lib/configure
     chmod a+x lib/configure
     echo "done."
else
     echo "No GNU m4. Impossible to build lib/configure -- aborting"
     exit
fi


So if GNUM4 is not set, you get:

-------------
Locating GNU m4... not found.
[...]
No GNU m4. Impossible to build lib/configure -- aborting

----------------

and the script exits, leaving an incomplete result of autogen.sh!
May patch exits at the very moment when GNUM4 appears to be not set.
It also replaces the if-statement above, since you're then sure
the GNUM4 is set!
All this is okay, since there's no way to configure/make properly
without doing the then-clause above.

Rob.




Reply via email to