Incidentally, Rob, I see some new code in FormBase::show that I
understand you added:
if (iconify_policy == 0) {
// set title for minimized form
string const minimize_title = title_;
fl_winicontitle(form()->window, minimize_title.c_str());
// assign an icon to form
string const iconname = LibFileSearch("images", "lyx", "xpm");
if (!iconname.empty()) {
unsigned int w, h;
Pixmap icon_mask;
Pixmap const icon_p = fl_read_pixmapfile(fl_root,
iconname.c_str(),
&w,
&h,
&icon_mask,
0, 0, 0); // this leaks
fl_set_form_icon(form(), icon_p, icon_mask);
}
}
I can see what it does and think that that's fine and dandy.
My problem lies with the comment "this leaks" and the fact that
you seem to create the Pixmap each and every time that the
dialog is shown.
would it not make sense to moce this block of code into the
if (minw_ == 0) {
}
block above it, so that the icon is created only once?
Similarly, something presumably needs to go in the d-tor to
destroy the Pixmap so that we can remove that "this leaks"
comment. Ie, you should make icon_p a member of FormBase.
Angus
