On Tuesday 24 September 2002 8:44 am, Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> | Is there a LyX policy for the correct place to #include
> | config.h? It seems that the Qt frontend does so in the
> | header files whilst the rest of LyX does so in the .C files.
> | Is there a reason or is it just an arbitrary difference?
>
> We usually _never_ include it in the header files, only in the
> .C files. (and then _always_ as the first file included.)
>
> Please fix this in the qt sources.
I've done so. My ChangeLog entry is:
* most files: "standard-conforming" Licence declaration.
Remove trailing whitespace.
* many header files: do not #include <config.h>
Remove unnecessary #includes by using forward declarations.
Add as first line: // -*- C++ -*-
Move several definitions of virtual functions out of line
as they are unlikely to be inlined anyway (and it reduces
header file dependencies)...
Ie, trivial stuff. One further point: many, many of these files
(in the qt2 directory) do not have a
#ifdef __GNUG__
#pragma interface / implementation
#endif
statement. Should I leave things as they are, add a statement to
those missing it or remove it from the remaining files, since
you've all been quite happily using g++ without any problems.
I'll post the patch to the list once it's finished.
Angus
