Lars Gullik Bjønnes wrote:
> "R. Lahaye" <[EMAIL PROTECTED]> writes:
> 
> | Hi,
> 
> | In the preferences dialog, Outputs->Misc->Papersize has a choice "default", which
> | I only can see as a nonsense option.
> 
> | 1) This so called "default" merely refers to the hard coded choice by LyX:
> |     src/lyxrc.C line 191
> |            default_papersize = BufferParams::PAPER_USLETTER;
> 
> |     This seems to me an arbitrary choice and does not deserve the alias "default".
> 
> | 2) Choose "default" here and save the settings. Reopening the Preferences dialog 
>will
> |     indeed show "default". However, closing/restarting LyX, will show you now "US 
>Letter"
> |     in the preferences page size.
> 
> |     So, after all, it's a fake "default".
> 
> | 3) The "default" is totally non-informative. It's much better to tell the user
> |     what the real papersize choice is here. That "default" is "US letter" is too 
>obscure.
> 
> | I suggest to get rid of the choice option "default" altogether.
> | Set the pagesize by default to something (US letter, A4, or whatever) but don't 
>call that
> | *the* default.
> 
> Wrong fix.

I don't agree qualifying this as "wrong fix"; I agree that the "default" should leave 
the paper
choice untouched, as Jean-Marc explains. But what the "default" does now is totally 
bullocks, and
need to go anyway (it's stupidly hardcoded to default everywhere to USLetter!).
I'd see the removal as step one. Step two is then, to (re)implement what it supposed 
to do.

Anyway, would a "better-fix" approach be:

1) keep the PAPER_DEFAULT in the papersize enum.

2) reimplement ALL papersize switches to actually recognize "PAPER_DEFAULT" as
    a separate entity, without automagically equalizing it to "PAPER_USLETTER".

3) The latter would also mean a change of the preferences file. At present both,
    "PAPER_DEFAULT" and "PAPER_USLETTER", result in no output to the preferences file,
    'cause they're equal.
    That must change. PAPER_DEFAULT: no output, PAPER_USLETTER: output usletter to 
preferences file!

Would that get approval?

BTW: My total patch to present CVS is really big now (mainly to Xforms dialogs and 
related code)
and I start worrying how to merge it in, eventually. It's fun to contribute and 
improve the code,
but I don't want my efforts to be waisted.
What shall I do? Stop right here, wait till later and hope for the best, or what?

Thanks,

Regards,
Rob.

Reply via email to