On Saturday 07 September 2002 9:36 pm, Martin Vermeer wrote:
> Why in insets/insetgraphics.C:
>
> 686 string const message = file_exists ?
> 687 string() : string("bb = 0 0 200 100, draft, type=eps]");
>
> ...
>
> 711 if (!opts.empty() && !message.empty())
> 712 before += ("[%\n" + opts + ',' + message);
> 713 else if (!message.empty())
> 714 before += ("[%\n" + message);
> 715 else if (!opts.empty())
> 716 before += ("[%\n" + opts + ']');
>
> ?
>
> Isn't it better to put out the final ']' always in the latter part?
> Would even allow simplification of the logic.
>
> Am I missing something?
No. This is a clear example of obfuscated code. Feel free to make it obvious.
Angus
