On Wednesday 28 August 2002 14:40, Dekel Tsur wrote:
> On Wed, Aug 28, 2002 at 02:37:34PM +0100, José Abílio Oliveira Matos wrote:
> > > Log message:
> > >   Don't use .extend() (doesn't work in python 1.5)
> >
> >   Why?
> >   Extend really works with 1.5.2 that should be our target.
>
> It doesn't work with 1.5.1

  We should require 1.5.2 that should be our minimum.
  If we could use 2.2 we would be able to reduce the code by 1/3 at least. :-)

> >   The code you have now will not work, because of the scope declaration,
> > lines is declared inside the function so will not be returned.
>
> I've noticed that and committed a fix.
> Now, I use
>      lines[i:j] = new_table
>
> (which is shorter than the .extend code)
  Ok, this is a better idiom, and a lot easier to read and see what is going 
on. :-)

-- 
José Abílio

Reply via email to