>>>>> "John" == John Levon <[EMAIL PROTECTED]> writes:

John> On Fri, Jun 21, 2002 at 12:09:34PM -0700, Matt Brennan wrote:
>>  As I recal, in v.1.1, you were able to create a new file by typing
>> its name in the File->Open... popup. Now in v. 1.2 this is no
>> longer possible. Hopefully, it should be easy to carry this feature
>> forward to v.1.2.1

John> JMarc, OK for 1.2 branch ?

Questions:

+               Buffer * buffer =  bufferlist.newFile(filename, "");

I thought that the second argument to newFile was a bool.

+               // the user specifically chose this name. Believe them.

Did you test what happens when one chooses a nonsensical file name
(non-existing directory, for example) and then tries to save? Failing
to save is OK, crashing lyx is not :)

Othrwise, I am OK in principle for this patch in 1.2.x.

JMarc

Reply via email to