On Fri, Jul 26, 2002 at 02:28:34PM +0200, Ruurd Reitsma wrote: > Well, it could. However, most _WIN32 #ifdefs outside of support are one-time > issues that would need very specific helper functions. Anyway, the __EMX__ > stuff is also still there.
So that should probably be moved, too. > > +++ src/graphics/GraphicsParams.h 2002/07/26 10:11:41 > > @@ -19,6 +19,9 @@ > > #include "GraphicsTypes.h" > > #include "LString.h" > > > > +#ifndef uint > > +typedef unsigned int uint; > > +#endif > > > > > > Why is that needed? > > GraphicsImageXPM.C needs it. It should move elsewhere, I agree. Its not really needed, line 562 there should be something like return static_cast<unsigned int>(i); > > #include <cstdlib> > > #include <csignal> > > > > +#include "support/os.h" > > + > > using std::vector; > > using std::endl; > > > > > > > > Why? > > Os.h throws in some POSIX signal defs if it detects _SIGNAL_H_ Headers should be self-contained, shouldn't they? So I thnik the proper way to do it is to include <csignal> in support/os.h. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
