On Mon, Jun 17, 2002 at 10:05:34PM +0200, Herbert Voss wrote:

> please test and apply it, if it's ok.

I'm about to test this now. A couple of things :

> +     // do not post a message, let the calling function decide
> +     // what to do here ...
> +//           Alert::alert(_("Cannot convert file"),
> +//                      _("No information for converting from ")
> +//                      + formats.prettyName(from_format) + _(" to ")
> +//                      + formats.prettyName(to_format));

I've just removed this code altogether.

> +     // if we have a zipped file, then delete the local copy of the 
> +     // unzipped one
> +//   if (zippedFile(filename_))
> +//           lyx::unlink(filename);

What is your intention here ? I think this is dead code, and removed it
totally.

> -     return DestroyTmpDir (tmpdir, false); // Why false?
> +//   return DestroyTmpDir (tmpdir, false); // Why false?
> +
> +     // changed it to true to get all temporary unzipped
> +     // files deleted, too.             Herbert 20020617
> +     return DestroyTmpDir (tmpdir, true); 

similar here

regards
john

-- 
"If a thing is not diminished by being shared, it is not rightly owned if
 it is only owned & not shared."
        - St. Augustine

Reply via email to